Add ability to send targeted company shares #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a breaking change to the add_company_share method. We
now parse the response body so the user does not have to parse the xml
response body. This change should not impact many users seeing as the
add_company_share method was just added a while ago and there hasn't
been a release since.
Usage:
response = client.add_company_share("2414183", {
:comment => "Testing, 1, 2, 3",
:targets => {
:geos => ['as', 'eu'],
:jobFunc => ['acct', 'bd']
}
puts "ID: #{response.body.update_key}"
puts "URL: #{response.body.update_url}"
|
|
||
| define_method :load_template do |template| | ||
| return cache[template] if cache[template] | ||
| mutex.synchronize do |
There was a problem hiding this comment.
During your testing did you run into race conditions?
There was a problem hiding this comment.
Any time I modify a shared variable I want to make sure it's serialized. Though in this case if multiple threads read and compile the same template it's not really the end of the world.
|
Thanks for the awesome code review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a breaking change to the add_company_share method. We
now parse the response body so the user does not have to parse the xml
response body. This change should not impact many users seeing as the
add_company_share method was just added a while ago and there hasn't
been a release since.
Usage: