Updates to master #55
Conversation
|
Just wanted to +1 this pull request. Renato's fork made the gem work for me. |
|
+1 This works for me too. If there's a reason this can't be merged, please let us know so we can clean it up. |
|
+1, this also fixed the gem for me. |
|
+1 |
1 similar comment
|
+1 |
|
+1 merge it please |
|
+1 For merge please! |
|
@berkes, it is possible to cherrypick commits, but not with github web UI yet AFAIK. edit: although changes should also be reflected in examples/documentation I guess. |
|
@berkes agreed I am using not only the fix but also the companies API. Should @renatosnrg split it up ? Not sure if this is what is holding the committers/Josh from accepting it. |
|
I am very willing to make this into separate pull-requests, if that is what is keeping @josh or @wynnetherland from committing. |
|
I'm gonna give this a +2 now, please :) |
|
I believe @josh can pick the commits he wants to merge, he doesn't need to merge all of them. By the way, Github automatically added my other commits to this pull request. Originally, only the first one was used to generate this pull request. |
|
Hey all... I merged in the pull request for the site paramater and bumped the version of the gem |
|
Thank you! |
|
@renatosnrg can you please submit another pull request for the companies piece which was also in this pull request ? |
Hi Josh,
I've added the site parameter to consumer oauth options. It's related to the issue #51, when we try to authorize from a previous stored user token (authorize_from_access).
Without the site parameter the consumer HTTP object couldn't be created correctly. It works with "get_request_token" because the request_token_url is a complete url, this way the HTTP object is created directly. But using "authorize_from_access" the oauth gem needs the site option to create the correct HTTP object.
Renato