update form mixin, fixes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokevnin
reviewed
Aug 14, 2017
src/index.js
Outdated
| @@ -33,6 +33,10 @@ export default () => { | |||
| await next(); | |||
| }); | |||
| app.use(bodyParser()); | |||
| app.use(async (ctx, next) => { | |||
| ctx.request.body = { ...ctx.request.body, ...ctx.request.query }; | |||
There was a problem hiding this comment.
вот так нельзя делать, body может быть чем угодно, в том числе бинарными данными
There was a problem hiding this comment.
тогда необходимо переписать следующую миддлвару, где if (req.body && typeof req.body === 'object' && '_method' in req.body) ?
There was a problem hiding this comment.
if (req.body && typeof req.body === 'object' && '_method' in req.query) {
// eslint-disable-next-line
return req.query._method;
}
There was a problem hiding this comment.
проблема в том что ты отправляешь _method в query, а его надо отправлять в body
There was a problem hiding this comment.
генерируя скрытый элемент формы (посмотри на хекслете форму редактирования аккаунта)
There was a problem hiding this comment.
понял, добавить: <input type="hidden" name="_method" value="patch">
There was a problem hiding this comment.
обновил миксин и реквест
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Миксин для формы:
mixin formFor(f, options = { <url>, <method> })Если метод
get || post, то создается обычная форма;Если другой метод, то
method="post", аaction=<url>?_method=<method>index.js
Добавил миддлвару. Без нее
bodyParserне добавляет вctx.request.bodyпараметры изctx.request.query(необходимо для передачи_method)DEBUG=
в Makefile:
DEBUG="application:*", а в logger.js былоconst log = debug('app');