added support jsdom for jest #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokevnin
reviewed
Jul 25, 2021
package.json
Outdated
| @@ -43,6 +44,6 @@ | |||
| "url-loader": "^4.1.1", | |||
| "webpack": "^5.46.0", | |||
| "webpack-cli": "^4.7.2", | |||
| "webpack-dev-server": "^3.11.2" | |||
| "webpack-dev-server": "^1.16.5" | |||
There was a problem hiding this comment.
Воу) это что-то слишком древняя версия
mokevnin
reviewed
Jul 25, 2021
__tests__/test.js
Outdated
| @@ -1,4 +1,6 @@ | |||
| // @ts-check | |||
| /** | |||
| * @jest-environment jsdom | |||
There was a problem hiding this comment.
Тут правильно это делать на уровне конфига
mokevnin
reviewed
Jul 25, 2021
.idea/.gitignore
Outdated
| @@ -0,0 +1,5 @@ | |||
| # Default ignored files | |||
There was a problem hiding this comment.
Директории .idea не должно быть внутри репозитория
mokevnin
reviewed
Jul 25, 2021
template.html
Outdated
Comment on lines
2
to
9
| <html lang='en'> | ||
| <head> | ||
|
|
||
| <title>Webpack template</title> | ||
| </head> | ||
| <body> | ||
| <div id='point'></div> | ||
| </body> |
|
Здравствуйте, Кирилл! Исправил все замечания. |
|
👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.