Add leap year task #402
Merged
Add leap year task #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #403 |
vtm9
requested changes
Jul 5, 2020
imamatory
reviewed
Jul 5, 2020
| :arguments [2020]}]) | ||
|
|
||
| (defn solution [year] | ||
| (if (and (zero? (mod year 4)) (not (and (zero? (mod year 100)) (not= (mod year 400) 0)))) true false)) |
There was a problem hiding this comment.
предлагаю убрать if, так как внутри итак булево выражение и не нужно его явно отображать. А для явности выражения использовать let чтобы дать поясняющие имена составляющим выражение частям.
There was a problem hiding this comment.
Я что-то слишком сильно зациклился на решении первоисточника)
Такой вариант лучше будет?
(defn solution [year] (cond (zero? (mod year 400)) true (zero? (mod year 100)) false (zero? (mod year 4)) true :default false))
There was a problem hiding this comment.
А,черт.форматирование сломалось, сейчас комитну тогда
There was a problem hiding this comment.
(zero? (mod year 400)) уже булево выражение, его можно ни в if ни в cond не писать.
предлагаю что-то вроде такого
(defn solution [year]
(letfn [(divisible? [a b]
(zero? (mod a b)))]
(and (divisible? year 4) (not (divisible? year 400))))) 
imamatory
approved these changes
Jul 6, 2020
imamatory
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.