removed github link for bots #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtm9
requested changes
Apr 23, 2021
| @@ -92,10 +89,15 @@ const UserProfile = () => { | |||
| </div> | |||
| <h1 className="mt-5 mb-0"> | |||
| {stats.user.name} | |||
| {stats.user.githubId && ( | |||
| <a className="text-muted" href={`https://github.com/${stats.user.githubName}`}> | |||
| {stats.user.githubId && stats.user.githubName ? ( | |||
There was a problem hiding this comment.
better to do just
stats.user.githubName
There was a problem hiding this comment.
@Surtt И еще вопрос, зачем было переходить на тернарный оператор?
ReDBrother
previously approved these changes
Apr 23, 2021
| @@ -92,10 +89,15 @@ const UserProfile = () => { | |||
| </div> | |||
| <h1 className="mt-5 mb-0"> | |||
| {stats.user.name} | |||
| {stats.user.githubId && ( | |||
| <a className="text-muted" href={`https://github.com/${stats.user.githubName}`}> | |||
| {stats.user.githubId && stats.user.githubName ? ( | |||
There was a problem hiding this comment.
@Surtt И еще вопрос, зачем было переходить на тернарный оператор?
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
==========================================
+ Coverage 72.88% 72.93% +0.05%
==========================================
Files 108 108
Lines 1966 1966
==========================================
+ Hits 1433 1434 +1
+ Misses 533 532 -1
Continue to review full report at Codecov.
|
|
Здорово. Поздравляю с первым принятым пр ;) |
|
Благодарю :) |
|
Yay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Убрал ссылку на гитхаб у ботов в профиле юзера