Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remake lobbyWidget display, change css #1053

Closed
wants to merge 1 commit into from

Conversation

VladimirAfanasievFS
Copy link
Collaborator

Было : Чат не отображался полностью на странице, убегал вниз
Screenshot from 2021-09-12 18-17-48
Стало: Чат отображается всегда, в текущих играх появляется скролл
Screenshot from 2021-09-12 17-50-29

@VladimirAfanasievFS VladimirAfanasievFS requested review from vtm9, amshkv and ReDBrother and removed request for vtm9 September 12, 2021 15:19
@VladimirAfanasievFS
Copy link
Collaborator Author

Вопрос, высоту пришлось прокидывать начиная от body, решение верное?

@codecov-commenter
Copy link

Codecov Report

Merging #1053 (f622f22) into master (7e7a79d) will decrease coverage by 2.76%.
The diff coverage is 60.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1053      +/-   ##
==========================================
- Coverage   73.16%   70.39%   -2.77%     
==========================================
  Files         115      117       +2     
  Lines        2161     2381     +220     
==========================================
+ Hits         1581     1676      +95     
- Misses        580      705     +125     
Impacted Files Coverage Δ
services/app/lib/codebattle/bot/player_server.ex 60.75% <0.00%> (-5.91%) ⬇️
...app/lib/codebattle/generators/checker_generator.ex 64.06% <0.00%> (+0.57%) ⬆️
services/app/lib/codebattle/tournament.ex 77.77% <ø> (ø)
services/app/lib/codebattle/tournament/types.ex 75.00% <ø> (ø)
...es/app/lib/codebattle/utils/restore_tournaments.ex 0.00% <0.00%> (ø)
services/app/lib/codebattle_web/endpoint.ex 100.00% <ø> (ø)
...es/app/lib/codebattle_web/views/tournament_view.ex 57.14% <ø> (-5.36%) ⬇️
...pp/lib/codebattle_web/live/tournament/show_view.ex 43.43% <14.28%> (-8.63%) ⬇️
...app/lib/codebattle/tournament/global_supervisor.ex 45.45% <50.00%> (-4.55%) ⬇️
services/app/lib/codebattle/tournament/team.ex 92.59% <60.00%> (-4.08%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1a4dd...f622f22. Read the comment docs.

@vtm9
Copy link
Contributor

vtm9 commented Sep 3, 2022

@VladimirAfanasievFS , YO, спасибо за ПР, можешь его обновить? я пока его закрою, ибо решил почистить все старое

@vtm9 vtm9 closed this Sep 3, 2022
@vtm9 vtm9 deleted the remake_lobbyWidget_display branch November 6, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants