Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different tab sizes depending on language #1116

Conversation

letzabelin
Copy link
Contributor

@letzabelin letzabelin commented Jul 7, 2022

Взял за основу логику из hexlet-basics.

Учёл изменение языка из выпадающего списка в componentDidUpdate

github-icon closes #1081

@ReDBrother ReDBrother self-requested a review July 7, 2022 16:01
@ReDBrother
Copy link
Collaborator

Ошибки линтера пофиксить и можно будет принять)

@codecov-commenter
Copy link

Codecov Report

Merging #1116 (9a650ac) into master (2e4cb0d) will increase coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
+ Coverage   70.01%   70.32%   +0.30%     
==========================================
  Files         125      125              
  Lines        2608     2608              
==========================================
+ Hits         1826     1834       +8     
+ Misses        782      774       -8     
Impacted Files Coverage Δ
services/app/lib/codebattle/bot/player_server.ex 64.55% <0.00%> (+3.79%) ⬆️
...es/app/lib/codebattle_web/channels/game_channel.ex 85.00% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e4cb0d...9a650ac. Read the comment docs.

@ReDBrother ReDBrother merged commit 82dc216 into hexlet-codebattle:master Jul 7, 2022
@letzabelin letzabelin deleted the use_different_tab_sizes_depending_on_language branch July 7, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Улучшить работу с отступами
3 participants