Users rating list #1504
Merged
Users rating list #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReDBrother
requested changes
Jun 18, 2023
Comment on lines
+169
to
+189
| {/* begin select */} | ||
| <div className="form-group ml-auto"> | ||
| <label htmlFor="usersPerPage"> | ||
| <select | ||
| className="custom-select" | ||
| id="usersPerPage" | ||
| onChange={e => { | ||
| setPageSize(e.target.value); | ||
| setPage(1); | ||
| }} | ||
| > | ||
| <option>20</option> | ||
| <option>30</option> | ||
| <option>40</option> | ||
| <option>50</option> | ||
| </select> | ||
| <span className="ml-2">Users per page</span> | ||
| </label> | ||
| </div> | ||
| {/** end select */} | ||
| <div className="form-check ml-3"> |
| @@ -20,6 +20,6 @@ const iconsToClass = { | |||
| php: 'icon-php-alt', | |||
| }; | |||
|
|
|||
| const LanguageIcon = ({ lang }) => <span className={cn('d-flex pt-2', iconsToClass[lang])} />; | |||
| const LanguageIcon = ({ lang }) => <span className={cn('d-flex', iconsToClass[lang])} />; | |||
There was a problem hiding this comment.
Проблема в том, что поправлен кейс в профиле пользователя, а все остальные кейсы упали. Например: лобби -> список игр
There was a problem hiding this comment.
Ок. Посмотрю исправлю.
There was a problem hiding this comment.
Не, мой косяк. Safari плохо дружит с нашими иконками. Буд уже сам думать как обойти
|
Сорри, даже не так. На разных браузерах эти иконки по разному центрируются. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1452
ну и от себя: