Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roma sub feature #1663

Merged
merged 8 commits into from
Nov 18, 2023
Merged

Conversation

RomaSub
Copy link
Contributor

@RomaSub RomaSub commented Nov 16, 2023

исправил максимальное количество символов вводимых в чат и отвязку линков

@ReDBrother ReDBrother self-requested a review November 16, 2023 16:43
@ReDBrother
Copy link
Collaborator

Это в мастере тесты попадали, исправлю и перезапустим билд

@@ -44,7 +52,7 @@ export default function ChatInput({ inputRef, disabled = false }) {
targetUserId: activeRoom.targetUserId,
},
};
if (isTooltipVisible) {
if (isTooltipVisible || isMaxLengthExceeded) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот только после этого у нас input с ошибкой показываться не будет

В остальном, все в порядке)

@ReDBrother
Copy link
Collaborator

Тут куча всего сделано разом, можешь сюда кинуть все номера ишью, которые пофиксил. Чтобы можно было закрыть их.

@RomaSub
Copy link
Contributor Author

RomaSub commented Nov 18, 2023

#1485
#1300
#1285

@ReDBrother ReDBrother merged commit 8cbbc5e into hexlet-codebattle:master Nov 18, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants