Live view to js #616
Closed
Live view to js #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexemtoxa
commented
Jan 27, 2020
| const diffMinutes = Math.floor((diffInMiliseconds/1000/60)); | ||
| const diffSeconds = Math.floor(((diffInMiliseconds/1000/60 - diffMinutes)*60)); | ||
|
|
||
| p.innerHTML = `Will start in ${diffMinutes} minutes ${diffSeconds} seconds`; |
There was a problem hiding this comment.
I have some doubts about inner html.. I don't know..is it right way?
There was a problem hiding this comment.
yep, let's follow this comment https://github.com/hexlet-codebattle/codebattle/pull/616/files#r371474316
imamatory
reviewed
Jan 27, 2020
| p.innerHTML = 'the tournament has begun'; | ||
| clearInterval(intervalId); | ||
| }; | ||
| }, 1000); |
There was a problem hiding this comment.
Што-то как-то труднее стало)) Как насчет вынести в реакт компонент и повесить его на p#timer?
There was a problem hiding this comment.
вот вопрос с inner html и отпал) спасибо)
There was a problem hiding this comment.
да, надо просто реакт компенент сделать. можно либку использовать, или самому data-attr заюзать
|
sorry, man |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.