Bumped Clojure and OpenJDK versions. Removed unnecessary option from… #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReDBrother
reviewed
Feb 9, 2020
| FROM clojure:openjdk-11-tools-deps-1.10.0.408 | ||
| FROM clojure:openjdk-13-tools-deps-1.10.1.502 |
There was a problem hiding this comment.
Если мы переходим на новую версию openjdk (у него будет своя версия компилятора), то нам необходимо обновить номер версии языка clojure для игроков:
https://github.com/hexlet-codebattle/codebattle/blob/add_linters/ansible/pull_dockers.yml
There was a problem hiding this comment.
There was a problem hiding this comment.
Обновил. Но, наверное, я зря так жестко версию зафиксировал?
There was a problem hiding this comment.
Не думаю что .502 связана с версией самого языка, это для этого image скорее верно.
В гитхабе проекта числится последним и стабильным 1.10.1 https://github.com/clojure/clojure/blob/master/changes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how important it is, but docker image is now a bit smaller as well -- 722MB vs 1.08GB