Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add statusColor.js, display firtsAssert #763

Conversation

VladimirAfanasievFS
Copy link
Collaborator

#746
про кнопку more не понял куда ее надо переместить?

@VladimirAfanasievFS
Copy link
Collaborator Author

image
image

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2020

Codecov Report

Merging #763 into master will decrease coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   77.46%   76.74%   -0.73%     
==========================================
  Files          85       85              
  Lines        1522     1522              
==========================================
- Hits         1179     1168      -11     
- Misses        343      354      +11     
Impacted Files Coverage Δ
services/app/lib/codebattle/languages.ex 100.00% <ø> (ø)
services/app/lib/codebattle/tournament.ex 72.00% <ø> (ø)
services/app/lib/codebattle/chat/server.ex 72.72% <0.00%> (-27.28%) ⬇️
...es/app/lib/codebattle_web/channels/chat_channel.ex 80.00% <0.00%> (-16.67%) ⬇️
...es/app/lib/codebattle_web/channels/game_channel.ex 80.32% <0.00%> (-6.56%) ⬇️
services/app/lib/codebattle/bot/player_server.ex 59.09% <0.00%> (+3.03%) ⬆️
services/app/lib/codebattle/bot/chat_client.ex 9.52% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959c976...3dd8753. Read the comment docs.

<AccordeonBox.SubMenu
statusColor={color[firstAssert.status]}
assert={firstAssert}
hasOutput={firstAssert.output}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasOutput={!!firstAssert.output}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

или так firstAssert && renderFirstAssert(firstAssert)

vtm9
vtm9 previously approved these changes Aug 12, 2020
@vtm9
Copy link
Contributor

vtm9 commented Aug 12, 2020

@H9ko , можешь актуализировать?

@VladimirAfanasievFS
Copy link
Collaborator Author

Уф беда все сломал... Сделал другой пр

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants