Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#311] Add config params to component ReactMarkdown for corent parsing [ #788

Merged
merged 2 commits into from Sep 13, 2020

Conversation

mettled
Copy link
Contributor

@mettled mettled commented Sep 13, 2020

Ошибка в парсинге квадратных скобок возникала из-за того что react markdown использует для парсинга пакет remark-parse.
В обсуждении данной проблемы на гите react markdown предлагалось добавить функцию обработчик для ссылок.

После добавления функции обработчика, квадратные скобки [] и ссылки отображаются корректно.

@codecov-commenter
Copy link

Codecov Report

Merging #788 into master will decrease coverage by 1.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   79.53%   78.50%   -1.03%     
==========================================
  Files          87       87              
  Lines        1554     1554              
==========================================
- Hits         1236     1220      -16     
- Misses        318      334      +16     
Impacted Files Coverage Δ
services/app/lib/codebattle/chat/server.ex 72.72% <0.00%> (-27.28%) ⬇️
...es/app/lib/codebattle_web/channels/chat_channel.ex 80.00% <0.00%> (-20.00%) ⬇️
...es/app/lib/codebattle_web/channels/game_channel.ex 80.32% <0.00%> (-6.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ece0d...c215c73. Read the comment docs.

@ReDBrother ReDBrother merged commit ea8011e into hexlet-codebattle:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants