Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remake notification popup #802

Conversation

VladimirAfanasievFS
Copy link
Collaborator

#795
перенес нотификейшены
image
image
Но возникла проблема что теперь не хватает места для списка онлайн пользователей после завершения некоторых видов игр
image
Как лучше исправить данное перекрытие?

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #802 into master will increase coverage by 0.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #802      +/-   ##
==========================================
+ Coverage   78.78%   79.43%   +0.65%     
==========================================
  Files          88       88              
  Lines        1579     1595      +16     
==========================================
+ Hits         1244     1267      +23     
+ Misses        335      328       -7     
Impacted Files Coverage Δ
services/app/lib/codebattle/bot/chat_client.ex 0.00% <0.00%> (-9.10%) ⬇️
...pp/lib/codebattle_web/live/tournament/show_view.ex 65.30% <0.00%> (-2.78%) ⬇️
services/app/lib/codebattle/bot/player_server.ex 66.66% <0.00%> (-1.52%) ⬇️
services/app/lib/codebattle/tournament/helpers.ex 94.73% <0.00%> (-1.27%) ⬇️
services/app/lib/codebattle/tournament/types.ex 75.00% <0.00%> (ø)
services/app/lib/codebattle/game_process/play.ex 92.95% <0.00%> (ø)
...es/app/lib/codebattle_web/views/tournament_view.ex 75.00% <0.00%> (+3.57%) ⬆️
...es/app/lib/codebattle_web/channels/chat_channel.ex 96.66% <0.00%> (+16.66%) ⬆️
services/app/lib/codebattle/chat/server.ex 89.28% <0.00%> (+21.42%) ⬆️
services/app/lib/codebattle/tournament.ex 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7805635...f8217cb. Read the comment docs.

@VladimirAfanasievFS
Copy link
Collaborator Author

Исправил отображение, не стал уменьшать длину текста алертов. все равно много букв остается
image

@ReDBrother ReDBrother merged commit 87404a2 into hexlet-codebattle:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants