Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php template codestyle #814

Merged
merged 2 commits into from Sep 20, 2020

Conversation

fey
Copy link
Collaborator

@fey fey commented Sep 17, 2020

image

@fey fey marked this pull request as draft September 17, 2020 19:19
@fey fey marked this pull request as ready for review September 17, 2020 19:20
@fey fey marked this pull request as draft September 17, 2020 19:20
@fey fey force-pushed the fix/php-template-function branch 2 times, most recently from 9a8fe5d to 9f2a71b Compare September 20, 2020 15:28
@codecov-commenter
Copy link

Codecov Report

Merging #814 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   79.27%   78.96%   -0.32%     
==========================================
  Files          88       88              
  Lines        1597     1597              
==========================================
- Hits         1266     1261       -5     
- Misses        331      336       +5     
Impacted Files Coverage Δ
services/app/lib/codebattle/languages.ex 100.00% <ø> (ø)
services/app/lib/codebattle/chat/server.ex 67.85% <0.00%> (-21.43%) ⬇️
...es/app/lib/codebattle_web/channels/chat_channel.ex 80.00% <0.00%> (-16.67%) ⬇️
services/app/lib/codebattle/bot/player_server.ex 68.18% <0.00%> (+1.51%) ⬆️
services/app/lib/codebattle/bot/chat_client.ex 9.09% <0.00%> (+9.09%) ⬆️
...es/app/lib/codebattle_web/views/tournament_view.ex 75.00% <0.00%> (+12.50%) ⬆️
services/app/lib/codebattle/tournament.ex 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba86b0...3db08be. Read the comment docs.

@fey fey marked this pull request as ready for review September 20, 2020 16:57
@vtm9 vtm9 merged commit 25868aa into hexlet-codebattle:master Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants