803# LanguagePicker built with react-select #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReDBrother
previously approved these changes
Oct 18, 2020
Comment on lines
+49
to
+55
| <Select | ||
| styles={customStyle} | ||
| className="col-12 col-xl-7" | ||
| defaultValue={defaultLang} | ||
| onChange={changeLang} | ||
| options={options} | ||
| /> |
There was a problem hiding this comment.
Офигенно!, Мне даже обидно, что сразу не догадался предложить готовый компонент с логикой. Спасибо))
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
==========================================
- Coverage 79.46% 78.75% -0.71%
==========================================
Files 88 88
Lines 1597 1605 +8
==========================================
- Hits 1269 1264 -5
- Misses 328 341 +13
Continue to review full report at Codecov.
|
ReDBrother
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Переписал пикер на react-select. Библиотеку ставил через yarn. Финальная версия выбора языка программирования