Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #862

Merged
merged 4 commits into from Nov 3, 2020
Merged

Tutorial #862

merged 4 commits into from Nov 3, 2020

Conversation

VladimirAfanasievFS
Copy link
Collaborator

@VladimirAfanasievFS VladimirAfanasievFS commented Nov 1, 2020

#816
image
image
image
image
Пока переводить не стал. Тексты через i18n сделаю после одобрения.

мне не нравится проверка const isFirstTime = window.localStorage.getItem('tutorialPassed') === null; Получается опрос каждый рендер, как лучше поправить? Или это норм и операция не дорогая?

@VladimirAfanasievFS
Copy link
Collaborator Author

Может шаги другие надо было?

@codecov-io
Copy link

codecov-io commented Nov 1, 2020

Codecov Report

Merging #862 into master will increase coverage by 0.22%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
+ Coverage   79.27%   79.50%   +0.22%     
==========================================
  Files          88       88              
  Lines        1597     1605       +8     
==========================================
+ Hits         1266     1276      +10     
+ Misses        331      329       -2     
Impacted Files Coverage Δ
services/app/lib/codebattle/languages.ex 100.00% <ø> (ø)
services/app/lib/codebattle/bot/player_server.ex 66.66% <50.00%> (ø)
services/app/lib/codebattle/user/scope.ex 89.47% <75.00%> (-3.86%) ⬇️
...debattle_web/controllers/api/v1/user_controller.ex 88.88% <100.00%> (+1.38%) ⬆️
.../lib/codebattle_web/controllers/page_controller.ex 75.00% <100.00%> (+8.33%) ⬆️
...es/app/lib/codebattle_web/views/tournament_view.ex 75.00% <0.00%> (+12.50%) ⬆️
services/app/lib/codebattle/tournament.ex 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba86b0...6642aff. Read the comment docs.

@ReDBrother
Copy link
Collaborator

мне не нравится проверка const isFirstTime = window.localStorage.getItem('tutorialPassed') === null; Получается опрос каждый рендер, как лучше поправить? Или это норм и операция не дорогая?

Если её нельзя высунуть за сам функциональный компонент, то можно и так оставить.

@VladimirAfanasievFS
Copy link
Collaborator Author

image
image
image
Добавил возможность нажатия на выбор языка и кнопку проверки, добавил 5 шаг наведение на вывод результатов

@ReDBrother ReDBrother merged commit 162c54c into master Nov 3, 2020
@ReDBrother ReDBrother deleted the tutorial branch November 3, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants