Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checks render game, rename component #864

Merged
merged 2 commits into from Nov 4, 2020
Merged

Conversation

VladimirAfanasievFS
Copy link
Collaborator

@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #864 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   79.06%   78.75%   -0.32%     
==========================================
  Files          88       88              
  Lines        1605     1605              
==========================================
- Hits         1269     1264       -5     
- Misses        336      341       +5     
Impacted Files Coverage Δ
services/app/lib/codebattle/chat/server.ex 67.85% <0.00%> (-21.43%) ⬇️
...es/app/lib/codebattle_web/channels/chat_channel.ex 80.00% <0.00%> (-16.67%) ⬇️
...es/app/lib/codebattle_web/channels/game_channel.ex 80.32% <0.00%> (-6.56%) ⬇️
services/app/lib/codebattle/bot/player_server.ex 68.18% <0.00%> (+3.03%) ⬆️
services/app/lib/codebattle/game_process/play.ex 93.15% <0.00%> (+4.10%) ⬆️
services/app/lib/codebattle/bot/chat_client.ex 9.09% <0.00%> (+9.09%) ⬆️
...es/app/lib/codebattle_web/views/tournament_view.ex 75.00% <0.00%> (+12.50%) ⬆️
services/app/lib/codebattle/tournament.ex 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162c54c...b5dea1a. Read the comment docs.

@ReDBrother ReDBrother merged commit 605e195 into master Nov 4, 2020
@ReDBrother ReDBrother deleted the #816_guide_add_checks branch November 4, 2020 05:55
@@ -70,9 +71,14 @@ const steps = [
},
},
];
const GameWidgetTutorial = () => {
const GameWidgetGuide = () => {
const isNotStoredGame = useSelector(state => gameStatusSelector(state).status !== GameStatusCodes.stored);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Гайд имеет смысл показывать только для начавшейся игры (состояние playing), когда игрок впервые запускает батл. Нельзя показывать её не только для сохраненных игр (состояние stored), но так же и для просто завершенных (состояние game_over) и других пограничных состояний.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants