Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change lobby ui #873

Merged
merged 15 commits into from Nov 22, 2020
Merged

change lobby ui #873

merged 15 commits into from Nov 22, 2020

Conversation

vtm9
Copy link
Contributor

@vtm9 vtm9 commented Nov 22, 2020

Improve Lobby page

@codecov-io
Copy link

Codecov Report

Merging #873 (0fba7df) into master (13199e1) will decrease coverage by 1.32%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
- Coverage   79.88%   78.56%   -1.33%     
==========================================
  Files          88       89       +1     
  Lines        1601     1628      +27     
==========================================
  Hits         1279     1279              
- Misses        322      349      +27     
Impacted Files Coverage Δ
...s/app/lib/codebattle_web/channels/lobby_channel.ex 57.14% <75.00%> (+23.80%) ⬆️
services/app/lib/codebattle/user/scope.ex 89.47% <100.00%> (ø)
...debattle_web/controllers/api/v1/user_controller.ex 89.47% <100.00%> (+0.58%) ⬆️
services/app/lib/codebattle/chat/server.ex 67.85% <0.00%> (-21.43%) ⬇️
...es/app/lib/codebattle_web/channels/chat_channel.ex 80.00% <0.00%> (-16.67%) ⬇️
...es/app/lib/codebattle/code_check/checker_status.ex 65.62% <0.00%> (-6.79%) ⬇️
...es/app/lib/codebattle_web/channels/game_channel.ex 80.30% <0.00%> (-6.07%) ⬇️
services/app/lib/codebattle/bot/player_server.ex 66.66% <0.00%> (ø)
services/app/lib/codebattle/game_process/play.ex 89.04% <0.00%> (ø)
services/app/lib/codebattle/code_check/checker.ex 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13199e1...0fba7df. Read the comment docs.

@vtm9 vtm9 merged commit 78920c6 into master Nov 22, 2020
@vtm9 vtm9 deleted the change-lobby-ui branch November 22, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants