Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default bool for php template #874

Merged
merged 1 commit into from Dec 7, 2020

Conversation

fey
Copy link
Collaborator

@fey fey commented Nov 28, 2020

False - невалидное значение, должно быть false

@codecov-io
Copy link

Codecov Report

Merging #874 (634f4f0) into master (4abf0e1) will increase coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
+ Coverage   78.43%   79.36%   +0.92%     
==========================================
  Files          89       89              
  Lines        1628     1628              
==========================================
+ Hits         1277     1292      +15     
+ Misses        351      336      -15     
Impacted Files Coverage Δ
services/app/lib/codebattle/languages.ex 100.00% <ø> (ø)
services/app/lib/codebattle/bot/chat_client.ex 0.00% <0.00%> (-9.10%) ⬇️
services/app/lib/codebattle/bot/player_server.ex 66.66% <0.00%> (-1.52%) ⬇️
...es/app/lib/codebattle_web/channels/game_channel.ex 86.36% <0.00%> (+6.06%) ⬆️
...es/app/lib/codebattle_web/views/tournament_view.ex 75.00% <0.00%> (+12.50%) ⬆️
...es/app/lib/codebattle_web/channels/chat_channel.ex 96.66% <0.00%> (+16.66%) ⬆️
services/app/lib/codebattle/chat/server.ex 89.28% <0.00%> (+21.42%) ⬆️
services/app/lib/codebattle/tournament.ex 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abf0e1...634f4f0. Read the comment docs.

@ReDBrother ReDBrother merged commit d0fe1ef into hexlet-codebattle:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants