refactor ExtensionPopup #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
VladimirAfanasievFS
commented
Dec 1, 2020
VladimirAfanasievFS
commented
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
==========================================
+ Coverage 78.43% 79.17% +0.73%
==========================================
Files 89 89
Lines 1628 1628
==========================================
+ Hits 1277 1289 +12
+ Misses 351 339 -12
Continue to review full report at Codecov.
|
ReDBrother
reviewed
Dec 1, 2020
| </Button> | ||
| </Modal.Footer> | ||
| </Modal> | ||
| ); | ||
| }; | ||
|
|
||
| export default domElement => { | ||
| const lastCheckTime = window.localStorage.getItem('lastCheckTime'); | ||
| const nowTime = Date.now(); | ||
| const oneMonth = 1000 * 60 * 60 * 24 * 30; |
There was a problem hiding this comment.
Давай всё же не месяц, а два-три дня сделаем.
ReDBrother
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.