Remake output #928
Merged
Remake output #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
С логами Без логов Дополнительно сделано :
|
|
Посмотрите общие замечания, я когда их буду править может и тесты смогу поправить. |
ReDBrother
reviewed
Jan 11, 2021
| }; | ||
|
|
||
| const OutputTab = ({ sideOutput, side }) => { | ||
| const { successCount, assertsCount, status } = sideOutput; |
There was a problem hiding this comment.
Нельзя проводить дестракчинг, если данных может не быть.
There was a problem hiding this comment.
и на эту...
|
|
||
| const Output = ({ sideOutput }) => { | ||
| const { | ||
| status, output, result, asserts, |
There was a problem hiding this comment.
Вот на эту деструктаризацию ругается
| }; | ||
|
|
||
| const OutputTab = ({ sideOutput, side }) => { | ||
| const { successCount, assertsCount, status } = sideOutput; |
There was a problem hiding this comment.
и на эту...
Codecov Report
@@ Coverage Diff @@
## master #928 +/- ##
==========================================
+ Coverage 75.71% 75.77% +0.05%
==========================================
Files 93 93
Lines 1709 1709
==========================================
+ Hits 1294 1295 +1
+ Misses 415 414 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.