Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unbind for github and discord #955

Merged
merged 2 commits into from Feb 13, 2021
Merged

Add unbind for github and discord #955

merged 2 commits into from Feb 13, 2021

Conversation

vtm9
Copy link
Contributor

@vtm9 vtm9 commented Feb 13, 2021

Add unbind buttons for discord/github auths

@codecov-io
Copy link

Codecov Report

Merging #955 (d3b2555) into master (d92d1e1) will decrease coverage by 0.25%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   74.15%   73.90%   -0.26%     
==========================================
  Files         103      103              
  Lines        1869     1893      +24     
==========================================
+ Hits         1386     1399      +13     
- Misses        483      494      +11     
Impacted Files Coverage Δ
services/app/lib/codebattle/user.ex 100.00% <ø> (ø)
services/app/lib/codebattle/oauth/github_user.ex 77.14% <12.50%> (-19.16%) ⬇️
...codebattle_web/controllers/auth_bind_controller.ex 50.00% <50.00%> (ø)
services/app/lib/codebattle/oauth/user.ex 25.00% <75.00%> (+13.88%) ⬆️
services/app/lib/codebattle/oauth/discord_user.ex 97.14% <100.00%> (+0.08%) ⬆️
...ttle_web/controllers/api/v1/settings_controller.ex 100.00% <100.00%> (ø)
.../lib/codebattle_web/controllers/auth_controller.ex 34.78% <100.00%> (ø)
...es/app/lib/codebattle_web/channels/game_channel.ex 80.30% <0.00%> (-6.07%) ⬇️
services/app/lib/codebattle/bot/player_server.ex 65.21% <0.00%> (+1.44%) ⬆️
...es/app/lib/codebattle_web/channels/chat_channel.ex 100.00% <0.00%> (+3.33%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92d1e1...d3b2555. Read the comment docs.

@vtm9 vtm9 merged commit ae330fe into master Feb 13, 2021
@vtm9 vtm9 deleted the add-unbind branch February 13, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants