Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Проверить все кнопки, ссылки, которые ведут на открытие сниппета. #169

Closed
acidmaksim opened this issue Jan 23, 2023 · 2 comments · Fixed by #205
Closed

Bug: Проверить все кнопки, ссылки, которые ведут на открытие сниппета. #169

acidmaksim opened this issue Jan 23, 2023 · 2 comments · Fixed by #205
Labels
bug Something isn't working frontend The task is related to the frontend good first issue Good for newcomers

Comments

@acidmaksim
Copy link
Contributor

Summary

Нужно проверить работоспособность новых роутов в приложении. Мы сделали ресурсный роутинг, но при тестировании всплывали ошибки. Нужно их отловить и исправить.

Reproduction steps

Проверить все кнопки, ссылки, которые ведут на открытие сниппета. Проверить что они ведут на открытие снипета по новому роутингу.

Expected result

Переделать на новый, где надо. Новый: /{username}/snippets/{slug}

Actual result

Старый: /editor?snippet={id}

Browsers

No response

OS

No response
@acidmaksim acidmaksim added bug Something isn't working good first issue Good for newcomers frontend The task is related to the frontend labels Jan 23, 2023
@AnastasiaKv
Copy link
Contributor

Беру

This was referenced Jan 26, 2023
Closed
Closed
@AnastasiaKv AnastasiaKv mentioned this issue Feb 16, 2023
Merged
@AnastasiaKv
Copy link
Contributor

pr #205

@fey fey linked a pull request Feb 16, 2023 that will close this issue
Fix snippet links #205
Merged
This was referenced Feb 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend The task is related to the frontend good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix snippet links AnastasiaKv/runit
2 participants
@AnastasiaKv @acidmaksim