Изменить путь у кнопки "Начать кодить" #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2022 16:04
in buttons "Начать кодить"
before change i have error in ChromeDev tools: uncaught (in promise) referenceerror: process is not defined at __webpack_default_export__ with this error i see only landing page, links dosen`t works only black page
dzencot
reviewed
Dec 19, 2022
webpack.config.js
Outdated
| @@ -82,5 +83,8 @@ module.exports = { | |||
| new MiniCssExtractPlugin(), | |||
| // Add your plugins here | |||
| // Learn more about plugins from https://webpack.js.org/configuration/plugins/ | |||
| new webpack.ProvidePlugin({ | |||
| process: 'process/browser', | |||
There was a problem hiding this comment.
А это точно нужно? Если это для исправления ошибки, то уже пофикшено
There was a problem hiding this comment.
я это добавил, чтобы у меня открывались страницы, без этого только лэндинг видел. Если уже пофиксили, то думаю это не надо.
There was a problem hiding this comment.
Да, пофикшено, можно убрать.
There was a problem hiding this comment.
что то не могу понять, как убрать часть из коммита, чтоб изменения по ссылкам остались, а изменения веб пака отменить
There was a problem hiding this comment.
Да просто новый коммит накатите, с удалением строк.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Поменял путь на "/editor", открывается страница создания сниппета. Но без авторизации ничего не дает печатать так и должно быть? Или я что то не так сделал?