Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace minimatch with micromatch #36

Merged
merged 1 commit into from Sep 28, 2019
Merged

feat: replace minimatch with micromatch #36

merged 1 commit into from Sep 28, 2019

Conversation

curbengh
Copy link
Contributor

Supersede #33 (had issue with rebasing).

basename is enabled by default, which doesn't support **/*/file.css pattern with slash. I can add a condition to disable basename when slash is detected, if desired (in a separate PR).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7c15973 on curbengh:match into ed0dc29 on hexojs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7c15973 on curbengh:match into ed0dc29 on hexojs:master.

@curbengh curbengh merged commit 0297382 into hexojs:master Sep 28, 2019
@curbengh curbengh deleted the match branch September 28, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@curbengh @coveralls @SukkaW