Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use instanceof Date instead of isDate #7

Merged
merged 1 commit into from
Oct 7, 2018
Merged

Use instanceof Date instead of isDate #7

merged 1 commit into from
Oct 7, 2018

Conversation

yoshinorin
Copy link
Member

isDate is deprecated in node v4.

Please see node v4 change log

@yoshinorin
Use instanceof Date instead of isDate
71056b0 
* isDate is deprecated in node v4
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 71056b0 on YoshinoriN:use-instanceof-instead-of-isDate into 21a1d58 on hexojs:master.

segayuu
segayuu approved these changes Oct 7, 2018
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@segayuu segayuu merged commit 9fabb4e into hexojs:master Oct 7, 2018
@yoshinorin yoshinorin deleted the use-instanceof-instead-of-isDate branch October 7, 2018 12:30
@yoshinorin yoshinorin added this to the v1.0.0 milestone Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segayuu segayuu segayuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yoshinorin @coveralls @segayuu