Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to customize atom:icon #69

Merged
merged 2 commits into from
Dec 26, 2018
Merged

Add ability to customize atom:icon #69

merged 2 commits into from
Dec 26, 2018

Conversation

zbicin
Copy link
Contributor

@zbicin zbicin commented Dec 17, 2018

This PR improves PR #57 and adds possibility to customize atom:icon by specifying icon property in feed section of _config.yml.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2d76b69 on zbicin:master into 775c6aa on hexojs:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2d76b69 on zbicin:master into 775c6aa on hexojs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2d76b69 on zbicin:master into 775c6aa on hexojs:master.

tomap
tomap approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@tomap tomap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yoshinorin
yoshinorin reviewed Dec 26, 2018
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this change in my local machine. And it works well :)

@yoshinorin yoshinorin merged commit d02618d into hexojs:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin left review comments

@tomap tomap tomap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zbicin @coveralls @tomap @yoshinorin