Skip to content

Commit

Permalink
Merge 652ede0 into cb24274
Browse files Browse the repository at this point in the history
  • Loading branch information
yoshinorin committed Nov 13, 2018
2 parents cb24274 + 652ede0 commit db0ba3c
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 33 deletions.
42 changes: 21 additions & 21 deletions lib/i18n.js
@@ -1,6 +1,6 @@
'use strict';

var vsprintf = require('sprintf-js').vsprintf;
const vsprintf = require('sprintf-js').vsprintf;

function i18n(options) {
options = options || {};
Expand All @@ -14,9 +14,9 @@ function i18n(options) {
}

i18n.prototype.get = function(languages) {
var data = this.data;
var result = {};
var lang, langData, keys, key, i, leni, j, lenj;
const data = this.data;
const result = {};
let lang, langData, keys, key, i, leni, j, lenj;

if (languages) {
if (!Array.isArray(languages)) {
Expand Down Expand Up @@ -67,11 +67,11 @@ function flattenObject(data, obj, parent) {
obj = obj || {};
parent = parent || '';

var keys = Object.keys(data);
var key = '';
var item;
const keys = Object.keys(data);
let key = '';
let item;

for (var i = 0, len = keys.length; i < len; i++) {
for (let i = 0, len = keys.length; i < len; i++) {
key = keys[i];
item = data[key];

Expand All @@ -86,41 +86,41 @@ function flattenObject(data, obj, parent) {
}

i18n.prototype.__ = function(lang) {
var data = this.get(lang);
const data = this.get(lang);

return function() {
var len = arguments.length;
const len = arguments.length;
if (!len) return '';

var args = new Array(len);
const args = new Array(len);

for (var i = 0; i < len; i++) {
for (let i = 0; i < len; i++) {
args[i] = arguments[i];
}

var key = args.shift();
var str = data[key] || key;
const key = args.shift();
const str = data[key] || key;

return vsprintf(str, args);
};
};

i18n.prototype._p = function(lang) {
var data = this.get(lang);
const data = this.get(lang);

return function() {
var len = arguments.length;
const len = arguments.length;
if (!len) return '';

var args = new Array(len);
const args = new Array(len);

for (var i = 0; i < len; i++) {
for (let i = 0; i < len; i++) {
args[i] = arguments[i];
}

var key = args.shift();
var number = args.length ? +args[0] : 0;
var str = key;
const key = args.shift();
const number = args.length ? +args[0] : 0;
let str = key;

if (!number && data.hasOwnProperty(key + '.zero')) {
str = data[key + '.zero'];
Expand Down
24 changes: 12 additions & 12 deletions test/index.js
@@ -1,11 +1,11 @@
'use strict';

var should = require('chai').should();
const should = require('chai').should();

describe('i18n', function() {
var Ctor = require('../lib/i18n');
const Ctor = require('../lib/i18n');

var i18n = new Ctor({
const i18n = new Ctor({
languages: ['zh-TW', 'en']
});

Expand Down Expand Up @@ -38,7 +38,7 @@ describe('i18n', function() {
});

it('construCtor', function() {
var i18n = new Ctor();
let i18n = new Ctor();
i18n.languages.should.eql(['default']);

i18n = new Ctor({
Expand All @@ -55,7 +55,7 @@ describe('i18n', function() {
});

it('set()', function() {
var i18n = new Ctor();
const i18n = new Ctor();

i18n.set('en', {
yes: 'Yes',
Expand Down Expand Up @@ -93,7 +93,7 @@ describe('i18n', function() {
});

it('get() - default languages', function() {
var result = i18n.get();
const result = i18n.get();

result.should.eql({
add: '新增',
Expand All @@ -107,7 +107,7 @@ describe('i18n', function() {
});

it('get() - custom languages', function() {
var result = i18n.get('en');
const result = i18n.get('en');

result.should.eql({
add: 'Add',
Expand All @@ -121,7 +121,7 @@ describe('i18n', function() {
});

it('remove()', function() {
var i18n = new Ctor();
const i18n = new Ctor();

i18n.set('en', {});
i18n.remove('en');
Expand All @@ -142,7 +142,7 @@ describe('i18n', function() {
});

it('__() - default languages', function() {
var __ = i18n.__();
const __ = i18n.__();

__().should.eql('');
__('add').should.eql('新增');
Expand All @@ -153,7 +153,7 @@ describe('i18n', function() {
});

it('__() - custom languages', function() {
var __ = i18n.__('en');
const __ = i18n.__('en');

__('add').should.eql('Add');
__('ok').should.eql('OK');
Expand All @@ -162,7 +162,7 @@ describe('i18n', function() {
});

it('_p() - default languages', function() {
var _p = i18n._p();
const _p = i18n._p();

_p().should.eql('');
_p('ok').should.eql('OK');
Expand All @@ -173,7 +173,7 @@ describe('i18n', function() {
});

it('_p() - custom languages', function() {
var _p = i18n._p('en');
const _p = i18n._p('en');

_p('ok').should.eql('OK');
_p('index.video', 0).should.eql('No videos');
Expand Down

0 comments on commit db0ba3c

Please sign in to comment.