Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image options #188

Merged
merged 3 commits into from
Sep 6, 2022
Merged

Conversation

renbaoshuo
Copy link
Member

@renbaoshuo renbaoshuo commented Aug 31, 2022

This pull request resolves #140, closes #141.

Usage

_posts/foo.md

![](bar.svg)

<!-- Also works: -->

![](foo/bar.svg)

will be rendered to:

<p><img src="/post/foo/bar.svg"></p>
<!-- Also works: -->
<p><img src="/post/foo/bar.svg"></p>

Note that for some local markdown editor previews, we need to use ![](foo/bar.svg) to display the image correctly. Adding support for this insertion format can bring users a good local writing experience.

@SukkaW SukkaW self-requested a review August 31, 2022 15:01
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fails on windows. Do you have any clues?

@renbaoshuo
Copy link
Member Author

CI fails on windows. Do you have any clues?

Nope.

@renbaoshuo
Copy link
Member Author

renbaoshuo commented Sep 4, 2022

CI fails on windows. Do you have any clues?

@SukkaW Fixed in 43dc603.

@renbaoshuo renbaoshuo merged commit ca32ac8 into hexojs:master Sep 6, 2022
@renbaoshuo renbaoshuo deleted the feature/image-options branch September 6, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postAsset config in markdown-it render
2 participants