Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autolink option should not apply on markdown syntax #162

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 29, 2020

link renderer method couldn't discern whether a link is inside [](), <>, http://example.com or www.example.com.

Meanwhile, url tokenizer is the method responsible for detecting http://example.com or www.example.com, so autolink option is more suitable there. (marked doesn't detect example.com, if a link doesn't starts with protocol (e.g. http://), a link must starts with www to be detected).

Fixes #139

@coveralls
Copy link

coveralls commented Aug 29, 2020

Coverage Status

Coverage decreased (-2.2%) to 97.849% when pulling 40d8204 on curbengh:fix-autolink into 29b49aa on hexojs:master.

@curbengh curbengh requested review from a team and removed request for stevenjoezhang August 30, 2020 05:57
@curbengh curbengh merged commit 0abcf7d into hexojs:master Aug 31, 2020
@curbengh curbengh deleted the fix-autolink branch August 31, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown link does not render correctly if include a backslash
3 participants