Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sinon #64

Merged
merged 4 commits into from
Oct 28, 2018
Merged

Update sinon #64

merged 4 commits into from
Oct 28, 2018
+7 −5

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Oct 26, 2018

No description provided.

@segayuu segayuu requested a review from a team October 26, 2018 01:34
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.495% when pulling 2c89e3d on Update-sinon into 9928aae on master.

@coveralls
Copy link

coveralls commented Oct 26, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 94.495% when pulling eade704 on Update-sinon into f0ef790 on master.

yoshinorin
yoshinorin approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoshinorin yoshinorin merged commit b518b37 into master Oct 28, 2018
@segayuu segayuu deleted the Update-sinon branch October 28, 2018 14:13
@segayuu
Copy link
Contributor Author

segayuu commented Oct 28, 2018

thank @yoshinorin !

@JLHwung JLHwung mentioned this pull request Nov 22, 2018
Closed
@yoshinorin yoshinorin added this to the v0.4.0 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@segayuu @coveralls @yoshinorin