fix(stripHTML): should be more strict with non string (#265)

And strip them :)
hexojs · Nov 7, 2021 · dd530da · dd530da
1 parent ce27f06
commit dd530da
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/strip_html.js b/lib/strip_html.js
@@ -5,6 +5,11 @@ const STATE_HTML = Symbol('html');
 const STATE_COMMENT = Symbol('comment');
 
 function striptags(html = '') {
+  // if not string, then safely return an empty string
+  if (typeof html !== 'string' && !(html instanceof String)) {
+    return '';
+  }
+
   let state = STATE_PLAINTEXT;
   let tag_buffer = '';
   let depth = 0;

diff --git a/test/strip_html.spec.js b/test/strip_html.spec.js
@@ -51,4 +51,11 @@ describe('stripHTML', () => {
 
     stripHTML(html).should.eql(text);
   });
+
+  it('should strip non string parameters', () => {
+    const html = ['X'];
+    const text = '';
+
+    stripHTML(html).should.eql(text);
+  });
 });