Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle url with hash, query, auth and port #85

Merged
merged 4 commits into from Sep 14, 2019
Merged

fix: handle url with hash, query, auth and port #85

merged 4 commits into from Sep 14, 2019

Conversation

curbengh
Copy link
Contributor

Fixes #83

@coveralls
Copy link

coveralls commented Sep 12, 2019 •
edited

Coverage Status

Coverage increased (+0.05%) to 96.0% when pulling 68e89d6 on curbengh:hash-search into a3abc36 on hexojs:master.

@curbengh
Copy link
Contributor Author

The URL API mentions path includes pathname and query, but
format({ path: encodeURI(decodeURI(parse(str).path)) })
doesn't output path nor query, thus pathname is used instead.

@curbengh curbengh mentioned this pull request Sep 14, 2019
Open
SukkaW
SukkaW reviewed Sep 14, 2019
View reviewed changes
lib/encode_url.js Outdated Show resolved Hide resolved
@curbengh curbengh changed the title fix: handle url with hash and query fix: handle url with hash, query, auth and port Sep 14, 2019
@curbengh curbengh merged commit 8daee5b into hexojs:master Sep 14, 2019
@curbengh curbengh deleted the hash-search branch September 14, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encodeURL() will lose hash in URL
3 participants
@curbengh @coveralls @SukkaW