Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle url with hash, query, auth and port #85

Merged
merged 4 commits into from Sep 14, 2019

Conversation

@curbengh
Copy link
Contributor

commented Sep 12, 2019

Fixes #83

curbengh added 2 commits Sep 10, 2019
@coveralls

This comment has been minimized.

Copy link

commented Sep 12, 2019

Coverage Status

Coverage increased (+0.05%) to 96.0% when pulling 68e89d6 on curbengh:hash-search into a3abc36 on hexojs:master.

@curbengh

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

The URL API mentions path includes pathname and query, but
format({ path: encodeURI(decodeURI(parse(str).path)) })
doesn't output path nor query, thus pathname is used instead.

lib/encode_url.js Outdated Show resolved Hide resolved
curbengh added 2 commits Sep 14, 2019
@curbengh curbengh changed the title fix: handle url with hash and query fix: handle url with hash, query, auth and port Sep 14, 2019
@SukkaW
SukkaW approved these changes Sep 14, 2019
@curbengh curbengh merged commit 8daee5b into hexojs:master Sep 14, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.05%) to 96.0%
Details
@curbengh curbengh deleted the curbengh:hash-search branch Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.