feat(tag): add unregister() method

hexojs · Jan 1, 2020 · 5179ccf · 5179ccf
1 parent a9bbc42
commit 5179ccf
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/lib/extend/tag.js b/lib/extend/tag.js
@@ -214,6 +214,12 @@ class Tag {
     this.env.addExtension(name, tag);
   }
 
+  unregister(name) {
+    if (!name) throw new TypeError('name is required');
+
+    if (this.env.hasExtension(name)) this.env.removeExtension(name);
+  }
+
   render(str, options, callback) {
     if (!callback && typeof options === 'function') {
       callback = options;

diff --git a/test/scripts/extend/tag.js b/test/scripts/extend/tag.js
@@ -161,6 +161,37 @@ describe('Tag', () => {
     errorCallback.calledOnce.should.be.true;
   });
 
+  it('unregister()', () => {
+    const tag = new Tag();
+
+    tag.register('test', (args, content) => Promise.resolve(args.join(' ')), {async: true});
+    tag.unregister('test');
+
+    return tag.render('{% test foo bar %}')
+      .then(result => {
+        console.log(result);
+        throw new Error('should return error');
+      })
+      .catch(err => {
+        err.should.have.property('type', 'unknown block tag: test');
+      });
+  });
+
+  it('unregister() - name is required', () => {
+    const errorCallback = sinon.spy(err => {
+      err.should.have.property('message', 'name is required');
+    });
+
+    try {
+      tag.unregister();
+    } catch (err) {
+      errorCallback(err);
+    }
+
+    errorCallback.calledOnce.should.be.true;
+  });
+
+
   it('render() - context', () => {
     const tag = new Tag();