Merge 16bd6d8 into a027779

hexojs · Jan 22, 2019 · 93217ab · 93217ab
2 parents a027779 + 16bd6d8
commit 93217ab
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/plugins/helper/partial.js b/lib/plugins/helper/partial.js
@@ -14,8 +14,7 @@ module.exports = ctx => function partial(name, locals, options = {}) {
   const viewLocals = { layout: false };
 
   if (!view) {
-    ctx.log.warn('Partial %s does not exist. %s', chalk.magenta(name), chalk.gray(`(in ${currentView})`));
-    return '';
+    throw new Error(`Partial ${name} does not exist. (in ${currentView})`);
   }
 
   if (options.only) {

diff --git a/test/scripts/helpers/partial.js b/test/scripts/helpers/partial.js
@@ -10,12 +10,13 @@ describe('partial', () => {
   const hexo = new Hexo(pathFn.join(__dirname, 'partial_test'), {silent: true});
   const themeDir = pathFn.join(hexo.base_dir, 'themes', 'test');
   const viewDir = pathFn.join(themeDir, 'layout') + pathFn.sep;
+  const viewName =  'article.swig'
 
   const ctx = {
     site: hexo.locals,
     config: hexo.config,
     view_dir: viewDir,
-    filename: pathFn.join(viewDir, 'post', 'article.swig'),
+    filename: pathFn.join(viewDir, 'post', viewName),
     foo: 'foo',
     cache: true
   };
@@ -43,7 +44,11 @@ describe('partial', () => {
     partial('widget/tag').should.eql('tag widget');
 
     // not found
-    partial('foo').should.eql('');
+    try {
+      partial('foo')
+    } catch (err) {
+      err.should.have.property('message', `Partial foo does not exist. (in post/${viewName})`);
+    }
   });
 
   it('locals', () => {