fix: Failed to create post with special character title (#5149)

hexojs · Feb 6, 2023 · d5f3f82 · d5f3f82
1 parent 4f2dde4
commit d5f3f82
Show file tree

Hide file tree

Showing 2 changed files with 87 additions and 1 deletion.
diff --git a/lib/hexo/post.js b/lib/hexo/post.js
@@ -191,7 +191,9 @@ const prepareFrontMatter = (data, jsonMode) => {
     } else if (moment.isDate(item)) {
       data[key] = moment.utc(item).format('YYYY-MM-DD HH:mm:ss');
     } else if (typeof item === 'string') {
-      if (jsonMode || item.includes(':') || item.startsWith('#') || item.startsWith('!!')) data[key] = `"${item}"`;
+      if (jsonMode || item.includes(':') || item.startsWith('#') || item.startsWith('!!')
+      || item.includes('{') || item.includes('}') || item.includes('[') || item.includes(']')
+      || item.includes('\'') || item.includes('"')) data[key] = `"${item.replace(/"/g, '\\"')}"`;
     }
   }
 

diff --git a/test/scripts/console/new.js b/test/scripts/console/new.js
@@ -247,4 +247,88 @@ describe('new', () => {
 
     await unlink(path);
   });
+
+  it('special character - 1', async () => {
+    const date = moment(now);
+    const path = join(hexo.source_dir, '_posts', 'Hello-World.md');
+    const body = [
+      'title: \'[Hello] World\'',
+      'foo: bar',
+      'date: ' + date.format('YYYY-MM-DD HH:mm:ss'),
+      'tags:',
+      '---'
+    ].join('\n') + '\n';
+
+    await n({
+      _: ['[Hello] World'],
+      foo: 'bar'
+    });
+    const content = await readFile(path);
+    content.should.eql(body);
+
+    await unlink(path);
+  });
+
+  it('special character - 2', async () => {
+    const date = moment(now);
+    const path = join(hexo.source_dir, '_posts', 'Hello-World.md');
+    const body = [
+      'title: \'{Hello} World\'',
+      'foo: bar',
+      'date: ' + date.format('YYYY-MM-DD HH:mm:ss'),
+      'tags:',
+      '---'
+    ].join('\n') + '\n';
+
+    await n({
+      _: ['{Hello} World'],
+      foo: 'bar'
+    });
+    const content = await readFile(path);
+    content.should.eql(body);
+
+    await unlink(path);
+  });
+
+  it('special character - 3', async () => {
+    const date = moment(now);
+    const path = join(hexo.source_dir, '_posts', 'Hello-World.md');
+    const body = [
+      'title: \'\'\'Hello\'\' World\'',
+      'foo: bar',
+      'date: ' + date.format('YYYY-MM-DD HH:mm:ss'),
+      'tags:',
+      '---'
+    ].join('\n') + '\n';
+
+    await n({
+      _: ['\'Hello\' World'],
+      foo: 'bar'
+    });
+    const content = await readFile(path);
+    content.should.eql(body);
+
+    await unlink(path);
+  });
+
+  it('special character - 4', async () => {
+    const date = moment(now);
+    const path = join(hexo.source_dir, '_posts', 'Hello-World.md');
+    const body = [
+      'title: \'"Hello" World\'',
+      'foo: bar',
+      'date: ' + date.format('YYYY-MM-DD HH:mm:ss'),
+      'tags:',
+      '---'
+    ].join('\n') + '\n';
+
+    await n({
+      _: ['"Hello" World'],
+      foo: 'bar'
+    });
+    const content = await readFile(path);
+    content.should.eql(body);
+
+    await unlink(path);
+  });
 });