-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vimeo video embed is by default non responsive #3225
Comments
Thinking twice about this, we might not want this behavior by default because it will not allow users to control the player with CSS so easily. If you think this is interesting, I could add the option in the vimeo tag as follows:
Closing this issue for now. |
My suggestion is:
Will default to a responsive video 100% width as provided by default by vimeo. Otherwise adding a width and height will return a video with specific size.
If width or height are not provided will fallback to responsive. |
This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I can do this myself, but I need some feedback by the core team before working on a PR. Otherwise, I'll close it. |
Indeed, that seems to be easily doable. If you look at other tags in this folder, you'll find a way to do what you want (optional parameters, ...) |
Nice, thanks for the feedback. |
This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Feature request
Set default vimeo embed code as provided in the vimeo website
Setting it as the provided embed code by Vimeo will give us by default responsive videos in posts using the vimeo helper tag provided by hexo.
The text was updated successfully, but these errors were encountered: