Vimeo video embed is by default non responsive

[Xaviju]

Feature request

Set default vimeo embed code as provided in the vimeo website

Setting it as the provided embed code by Vimeo will give us by default responsive videos in posts using the vimeo helper tag provided by hexo.

<div style="padding:56.25% 0 0 0;position:relative;">
  <iframe src="//player.vimeo.com/video/${video_id}?title=0&byline=0&portrait=0" style="position:absolute;top:0;left:0;width:100%;height:100%;" frameborder="0" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>
  </div>

[Xaviju]

Thinking twice about this, we might not want this behavior by default because it will not allow users to control the player with CSS so easily.

If you think this is interesting, I could add the option in the vimeo tag as follows:

{vimeo 324234 responsive}

Closing this issue for now.

[Xaviju]

My suggestion is:

{vimeo id}

Will default to a responsive video 100% width as provided by default by vimeo.

Otherwise adding a width and height will return a video with specific size.

{vimeo id width height}

If width or height are not provided will fallback to responsive.

[stale]

This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Xaviju]

I can do this myself, but I need some feedback by the core team before working on a PR. Otherwise, I'll close it.
If there is a better workflow for feature requests and PRs please let me know.

[tomap]

Indeed, that seems to be easily doable.
Are you willing to do a pull request.
Code is fairly simple:
https://github.com/hexojs/hexo/blob/0b26940f7e0a35f6937b944012468bbf0d844010/lib/plugins/tag/vimeo.js

If you look at other tags in this folder, you'll find a way to do what you want (optional parameters, ...)

[Xaviju]

Nice, thanks for the feedback.
I'll create the PR

[Xaviju]

#3283

[stale]

This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions.