Fix backtick_code_block for ignore tab character. #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<raw>``` (tab) Hello world! </new> The expressions like this causes a bug. In this case, `args` in backtickCodeBlock() is not blank (but a tab character). Then the `args` will not match both of rAllOptions and rLangCaption. So `match` will be `null`. and we can't get `match[1]` in this case. To fix it, I check whether `match` is null or not.
tommy351
added a commit
that referenced
this pull request
Apr 26, 2015
Fix backtick_code_block for ignore tab character.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expressions like this causes a bug.
In this case,
argsinbacktickCodeBlock()is not blank (it contains a tab character).Then the
argswill not match both ofrAllOptionsandrLangCaption.So
matchwill benull. and we can't getmatch[1]in this case.To fix it, I check whether
matchisnullor not.This pull request may solve #1228.