Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to be stored as devDependencies too. #2558

Merged
merged 1 commit into from
May 11, 2017

Conversation

lewiscowper
Copy link
Contributor

@lewiscowper lewiscowper commented May 11, 2017

When using a custom server, I would like to store only the output of hexo's build process, and no extra dependencies, and the way I can do that is by storing the plugins in devDep and running npm install --production to get the server dependencies.

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test. (this was failing on an untouched test on my machine, so I guess I'll have to wait and see what the CI does with the PR)

When using a custom server, I would like to store only the output of hexo's build process, and no extra dependencies, and the way I can do that is by storing the plugins in devDep and running npm install --production to get the server dependencies.
@coveralls
Copy link

coveralls commented May 11, 2017

Coverage Status

Coverage remained the same at 97.188% when pulling f6e20de on lewiscowper:add-dev-dependency-plugins into aeac61d on hexojs:master.

Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants