Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(probot-stale): add probot-stale configuration #2640

Merged
merged 1 commit into from Jul 8, 2017

Conversation

JLHwung
Copy link
Collaborator

@JLHwung JLHwung commented Jul 8, 2017

Resolve #2637.

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • [-] Add test cases for the changes.
  • [-] Passed the CI test.

Need Owner Membership of hexo to integrate probot-stale. See https://github.com/probot/stale#usage

@coveralls
Copy link

coveralls commented Jul 8, 2017

Coverage Status

Coverage remained the same at 97.152% when pulling ede480b on chore/probot-stale into 3ee44f4 on master.

Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NoahDragon NoahDragon merged commit c450e9b into master Jul 8, 2017
@NoahDragon NoahDragon deleted the chore/probot-stale branch July 8, 2017 02:22
@JLHwung
Copy link
Collaborator Author

JLHwung commented Jul 8, 2017

@NoahDragon The probot-stale needs owner membership to integrate, could you give it a try? See https://github.com/probot/stale#usage

@NoahDragon
Copy link
Member

@JLHwung Done. Thanks.

@JLHwung
Copy link
Collaborator Author

JLHwung commented Jul 8, 2017

You are very welcome.

@NoahDragon
Copy link
Member

@JLHwung One question about this probot. It seems not working. Is there something I didn't do it correctly?

@JLHwung
Copy link
Collaborator Author

JLHwung commented Jul 18, 2017

@NoahDragon The configuration should be straightforward and I can't find any complains on the issues of probot-stale. Just a reminder, have you select the Repository access to All Repository on the probot-stale installation page?

@NoahDragon
Copy link
Member

image
I only set it to access the hexo main repo, as the other repos don't have many issues to close.

@JLHwung
Copy link
Collaborator Author

JLHwung commented Jul 18, 2017

hmm, it should have been working. Maybe we can watch on this issue probot/stale#36.

And notice that the bot seems to checking issues in an infrequent interval, see probot/stale#33.

@NoahDragon
Copy link
Member

I see. Thanks for the help. I'll check those issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants