Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep assign replaced with lodash merge #2967

Merged
merged 2 commits into from
Jan 16, 2018
Merged

Deep assign replaced with lodash merge #2967

merged 2 commits into from
Jan 16, 2018

Conversation

tryshchenko
Copy link
Contributor

@tryshchenko tryshchenko commented Jan 15, 2018 •
edited
Loading

Fixes #2966

  • [Compatible with old ones. Runned and verified] Add test cases for the changes.
  • Passed the CI test.

@tryshchenko tryshchenko mentioned this pull request Jan 15, 2018
Closed
@coveralls
Copy link

coveralls commented Jan 15, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.256% when pulling 35559f1 on tryshchenko:deep-assign-to-lodash-merge into ca5065e on hexojs:master.

@JLHwung
Copy link
Collaborator

JLHwung commented Jan 15, 2018

Hi @tryshchenko,
Could you run npm uninstall deep-assign? Thank you.

@tryshchenko
Copy link
Contributor Author

Sure, I forgot about that, I have updated a pull request. Now it's gone.

@coveralls
Copy link

coveralls commented Jan 15, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.256% when pulling 152596b on tryshchenko:deep-assign-to-lodash-merge into ca5065e on hexojs:master.

@JLHwung JLHwung merged commit 9f9ec32 into hexojs:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tryshchenko @coveralls @JLHwung