Refactor helper pagenator #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segayuu
requested review from
yoshinorin and
a team
and removed request for
yoshinorin
JLHwung
reviewed
Nov 22, 2018
| base: this.page.base || '', | ||
| current: this.page.current || 0, | ||
| format: `${this.config.pagination_dir}/%d/`, | ||
| total: this.page.total || 1, |
There was a problem hiding this comment.
Will this.page.total be zero?
There was a problem hiding this comment.
Since the initial initial value was 1, it is being handed over.
|
This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
tomap
approved these changes
Mar 15, 2019
|
This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
2 tasks
…r-helper-pagenator
…r-helper-pagenator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complexity of
pagenatorHelperis46, it is too large as a single function, so we will distribute the complexity.