PR template with more information #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is to help new contributors and Hexo team to have more information to accept PRs.
It's easier to understand that way.
yoshinorin
reviewed
Jan 6, 2019
|
Thanks for having a look. I don't think anyone will object. Lets merge! 馃巺 |
ivan-nginx
approved these changes
Jan 6, 2019
yoshinorin
approved these changes
Jan 7, 2019
|
@tcrowe @ivan-nginx Thanks ! |
thom4parisot
pushed a commit
to thom4parisot/hexo
that referenced
this pull request
Jan 17, 2020
* PR template with more information The idea is to help new contributors and Hexo team to have more information to accept PRs. * change ??? to BRANCH and USER It's easier to understand that way.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The idea is to help new contributors and Hexo team to have more information to accept PRs. Anyone can help test with the instructions.
Screen shot
Is this good? 馃憤馃徎馃憥馃徎 @hexojs/core @hexojs/founder
If you like this maybe I can add it to every project in the future.
- [ ] Add test cases for the changes.