Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw error on missing partial #3413

Merged
merged 1 commit into from Jan 27, 2019
Merged

throw error on missing partial #3413

merged 1 commit into from Jan 27, 2019

Conversation

jakubgs
Copy link
Contributor

@jakubgs jakubgs commented Jan 7, 2019

Fixes: #3384

@coveralls
Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage decreased (-0.001%) to 97.261% when pulling c398b44 on jakubgs:master into a027779 on hexojs:master.

@tcrowe
Copy link
Contributor

tcrowe commented Jan 21, 2019

@jakubgs It's good and clean

@yoshinorin You said it's better to throw than log a message here. I'm not sure so I will defer to your judgement.

@yoshinorin
Copy link
Member

@tcrowe
It is possibility that user can not notice about broken layout, if only a log message. I think an exception is better than log message, in order to notice it to user.

I'm going to test it by my local machine. But I have been busy recently with daily routine. 😓 So, please wait patiently. Thanks :)

@tcrowe
Copy link
Contributor

tcrowe commented Jan 21, 2019

@yoshinorin No problem! If you want to I can do it. You may hand over any task to me or assign it to me until you are ready to come back.

@tomap
Copy link
Contributor

tomap commented Jan 22, 2019

There is an eslint error before validating

@tcrowe
Copy link
Contributor

tcrowe commented Jan 22, 2019

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs
Copy link
Contributor Author

jakubgs commented Jan 22, 2019

Now it seems the only blocker is the ridiculously small reduction in coverage. No idea what to do about that.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
@jakubgs Thanks.

@yoshinorin yoshinorin merged commit 00c6114 into hexojs:master Jan 27, 2019
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants