New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw error on missing partial #3413
Conversation
@jakubgs It's good and clean @yoshinorin You said it's better to throw than log a message here. I'm not sure so I will defer to your judgement. |
@tcrowe I'm going to test it by my local machine. But I have been busy recently with daily routine. 😓 So, please wait patiently. Thanks :) |
@yoshinorin No problem! If you want to I can do it. You may hand over any task to me or assign it to me until you are ready to come back. |
There is an eslint error before validating |
The tests fail here: |
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Now it seems the only blocker is the ridiculously small reduction in coverage. No idea what to do about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
@jakubgs Thanks.
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Fixes: #3384