Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to disable meta generator tag #3653

Merged
merged 2 commits into from Aug 6, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Aug 6, 2019

What does it do?

Add meta_generator option (enabled by default) to disable addition of <meta name="generator" content="Hexo 3.9.0">.

Fix #3652 (comment)

How to test

git clone -b meta-generator https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

cc @JoeyBling

curbengh added 2 commits Aug 6, 2019
@curbengh curbengh changed the title Meta generator feat: add option to disable meta generator tag Aug 6, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 6, 2019

Coverage Status

Coverage increased (+0.0008%) to 97.153% when pulling 5d592cc on curbengh:meta-generator into 9b87047 on hexojs:master.

@YoshinoriN YoshinoriN merged commit 0621184 into hexojs:master Aug 6, 2019
4 checks passed
4 checks passed
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0008%) to 97.153%
Details
@YoshinoriN

This comment has been minimized.

Copy link
Member

YoshinoriN commented Aug 6, 2019

It works well :)

IMO that it's nice if we disable meta_generator plugin here.

filter.register('after_render:html', require('./meta_generator'));

But, hexo ctx not yet load _config.yml settings when register filter/index.js.

@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Aug 6, 2019

But, hexo ctx not yet load _config.yml settings when register filter/index.js.

good catch

@curbengh curbengh deleted the curbengh:meta-generator branch Aug 6, 2019
curbengh added a commit to curbengh/hexo-starter that referenced this pull request Oct 11, 2019
- pretty_urls.trailing_index: hexojs/hexo#3691
- external_link.enable: hexojs/hexo#3675
- meta_generator: hexojs/hexo#3653
- use_date_for_updated: hexojs/hexo#3235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.