Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test-box-box): async/await #3965

Merged
merged 3 commits into from
Jan 8, 2020
Merged

refactor(test-box-box): async/await #3965

merged 3 commits into from
Jan 8, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 15, 2019 •
edited

What does it do?

#3328

How to test

git clone -b test-box-box-async https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Dec 15, 2019 •
edited

Coverage Status

Coverage remained the same at 97.086% when pulling 0aede08 on curbengh:test-box-box-async into 663f1eb on hexojs:master.

@SukkaW SukkaW merged commit bf3b377 into hexojs:master Jan 8, 2020
@curbengh curbengh deleted the test-box-box-async branch January 10, 2020 07:10
@curbengh curbengh mentioned this pull request Jan 10, 2020
Merged
2 tasks
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@curbengh
refactor(test-box-box): async/await (hexojs#3965)
cd0dcd1 
* refactor(test-box-box): async/await

* refactor(test-box-box): destructure

* refactor(test-box-box): arrow function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@curbengh @coveralls @SukkaW