Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toc_helper): add min_depth option #3997

Merged
merged 2 commits into from Dec 21, 2019
Merged

feat(toc_helper): add min_depth option #3997

merged 2 commits into from Dec 21, 2019

Conversation

SukkaW
Copy link
Member

@SukkaW SukkaW commented Dec 20, 2019 •
edited by curbengh

What does it do?

Add min_depth option.

The unit test for toc() has been refactored as well.

Supersedes and closes #3929

How to test

git clone -b toc_min_depth https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@SukkaW SukkaW requested a review from a team December 20, 2019 14:25
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.103% when pulling 0cfb532 on SukkaW:toc-min-depth into a381dda on hexojs:master.

curbengh
curbengh approved these changes Dec 21, 2019
View reviewed changes
Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@SukkaW SukkaW merged commit a4a3f82 into hexojs:master Dec 21, 2019
This was referenced Dec 21, 2019
Merged
Merged
@noraj
Copy link
Contributor

noraj commented Feb 23, 2020

Thanks a lot

@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curbengh curbengh curbengh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SukkaW @coveralls @noraj @curbengh