Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toc_helper): add min_depth option #3997

Merged
merged 2 commits into from Dec 21, 2019
Merged

Conversation

@SukkaW
Copy link
Member

SukkaW commented Dec 20, 2019

What does it do?

Add min_depth option.

The unit test for toc() has been refactored as well.

Supersedes and closes #3929

How to test

git clone -b toc_min_depth https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@SukkaW SukkaW requested a review from hexojs/core Dec 20, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 20, 2019

Coverage Status

Coverage remained the same at 97.103% when pulling 0cfb532 on SukkaW:toc-min-depth into a381dda on hexojs:master.

Copy link
Contributor

curbengh left a comment

tested

@SukkaW SukkaW merged commit a4a3f82 into hexojs:master Dec 21, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage remained the same at 97.103%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.