fix(processor): remove race condition failsafe #4791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
force-pushed
the
fix-race-condition
branch
from
b411032
to
2a6cbda
Compare
SukkaW
commented
Oct 2, 2021
Comment on lines
-166
to
172
| // FIXME: Data may be inserted when reading files. Load it again to prevent | ||
| // race condition. We have to solve this in warehouse. | ||
| const doc = Post.findOne({source: file.path}); | ||
|
|
||
| if (doc) { | ||
| if (file.type !== 'update') { | ||
| ctx.log.warn(`Trying to "create" ${magenta(file.path)}, but the file already exists!`); | ||
| } | ||
| return doc.replace(data); | ||
| } |
There was a problem hiding this comment.
There are only three reasons that a doc will already exist while the processor is trying to create a post:
- A race condition inside the warehouse (which seems to be fixed in warehouse@2.1.0 back in 2015)
- The
file.typeisupdate. in this case, there is no need to load thedocagain. - In some rare situation where two
fileobject is created, with the sameidand the samecreatetype (E.g. inside our unit test when we trying tocreate2files under the samefile.path. This is not likely to happen in the real-world production). But Hexo can still deal with the issue by replacingdocdirectly. And I add a warning message for the case, and hopefully, someone who encounters the issue would report it to us.
SukkaW
commented
Oct 2, 2021
Comment on lines
+314
to
+317
| return Promise.all([ | ||
| post.remove(), | ||
| unlink(file.source) | ||
| ]); |
There was a problem hiding this comment.
Both _Document.remove method and fs.unlink method returns Promise.
stevenjoezhang
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This closes #4430
How to test
Pull request tasks